Trensa-Organization/hy3
1
0
Fork 0
mirror of https://github.com/Trensa-Organization/hy3.git synced 2025-03-15 18:53:40 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix UAF in removeFromParentRecursive

Browse source
This commit is contained in:
outfoxxed 2023-05-14 22:44:19 -07:00
parent 1c98666342
commit 2a2cb5c8a0
No known key found for this signature in database
GPG key ID: 4C88A185FB89301E
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/Hy3Layout.cpp
View file

@ -332,6 +332,7 @@ Hy3Node* Hy3Node::removeFromParentRecursive() {
group.lastFocusedChild = group.children.front();
}
auto child_size_ratio = child->size_ratio;
if (child != this) {
parent->layout->nodes.remove(*child);
} else {
@ -344,7 +345,7 @@ Hy3Node* Hy3Node::removeFromParentRecursive() {
child_count -= 1;
}
auto splitmod = -((1.0 - child->size_ratio) / child_count);
auto splitmod = -((1.0 - child_size_ratio) / child_count);
for (auto* child: group.children) {
child->size_ratio += splitmod;