Trensa-Organization/hy3
1
0
Fork 0
mirror of https://github.com/Trensa-Organization/hy3.git synced 2025-03-15 18:53:40 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix UAF when collapsing children of ephemeral nodes in a shift

Browse source
This commit is contained in:
outfoxxed 2023-07-29 03:08:35 -07:00
parent 3fbaa4adf5
commit 84317d3d2a
No known key found for this signature in database
GPG key ID: 4C88A185FB89301E
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/Hy3Layout.cpp
View file

@ -1426,7 +1426,9 @@ Hy3Node* Hy3Layout::shiftOrGetFocus(
if (old_parent != nullptr) {
auto& group = old_parent->data.as_group;
if (old_parent->parent != nullptr && group.ephemeral && group.children.size() == 1) {
if (old_parent->parent != nullptr && group.ephemeral && group.children.size() == 1
&& !group.hasChild(&node))
{
Hy3Node::swallowGroups(old_parent);
}