Trensa-Organization/hy3
1
0
Fork 0
mirror of https://github.com/Trensa-Organization/hy3.git synced 2025-03-15 18:53:40 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix UB when removing nodes with faulty operator==

Browse source
This commit is contained in:
outfoxxed 2023-05-16 02:16:12 -07:00
parent 2a2cb5c8a0
commit 4c000cc03c
No known key found for this signature in database
GPG key ID: 4C88A185FB89301E
1 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/Hy3Layout.cpp
View file

@ -98,15 +98,7 @@ Hy3NodeData& Hy3NodeData::operator=(Hy3GroupLayout layout) {
}
bool Hy3NodeData::operator==(const Hy3NodeData& rhs) const {
if (this->type != rhs.type) return false;
switch (this->type) {
case Hy3NodeData::Window:
return this->as_window == rhs.as_window;
case Hy3NodeData::Group:
return this->as_group.children == rhs.as_group.children;
}
return false;
return this == &rhs;
}
bool Hy3Node::operator==(const Hy3Node& rhs) const {